Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coinjoin): add tracking of transactions #222

Merged
merged 12 commits into from
Aug 1, 2023
Merged

feat(coinjoin): add tracking of transactions #222

merged 12 commits into from
Aug 1, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering force-pushed the feature-coinjoin-improvements-1 branch from 0e5a32b to c236738 Compare July 18, 2023 14:12
@HashEngineering HashEngineering self-assigned this Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 32.61% and project coverage change: -0.35% ⚠️

Comparison is base (7adfe0c) 48.38% compared to head (919119f) 48.03%.
Report is 3 commits behind head on feature-coinjoin.

❗ Current head 919119f differs from pull request most recent head 4294b32. Consider uploading reports for the commit 4294b32 to get more accurate results

Additional details and impacted files 
@@                  Coverage Diff                   @@
##             feature-coinjoin     #222      +/-   ##
======================================================
- Coverage               48.38%   48.03%   -0.35%     
+ Complexity               7195     7188       -7     
======================================================
  Files                     449      450       +1     
  Lines                   49406    49611     +205     
  Branches                 7040     7068      +28     
======================================================
- Hits                    23903    23829      -74     
- Misses                  22766    23048     +282     
+ Partials                 2737     2734       -3
Files Changed Coverage Δ
.../main/java/org/bitcoin/crawler/PeerSeedProtos.java 0.00% <0.00%> (ø)
.../java/org/bitcoinj/coinjoin/PendingDsaRequest.java 64.28% <ø> (ø)
...coinj/coinjoin/progress/MixingProgressTracker.java 0.00% <0.00%> (ø)
.../org/bitcoinj/coinjoin/utils/CoinJoinReporter.java 0.00% <0.00%> (ø)
...main/java/org/bitcoinj/core/BitcoinSerializer.java 74.31% <0.00%> (+0.57%) ⬆️
core/src/main/java/org/bitcoinj/core/Message.java 72.54% <0.00%> (-2.29%) ⬇️
...main/java/org/bitcoinj/core/MessageSerializer.java 70.00% <0.00%> (-20.91%) ⬇️
core/src/main/java/org/bitcoinj/core/Peer.java 41.95% <ø> (ø)
...main/java/org/bitcoinj/core/PeerSocketHandler.java 51.08% <ø> (-8.06%) ⬇️
...g/bitcoinj/evolution/CreditFundingTransaction.java 63.75% <ø> (ø)
... and 25 more

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Syn-McJ
Syn-McJ approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some commented code in MasternodeGroup.java which might need a cleanup.

@HashEngineering HashEngineering merged commit c16ca38 into feature-coinjoin Aug 1, 2023
3 of 4 checks passed
@HashEngineering HashEngineering deleted the feature-coinjoin-improvements-1 branch September 26, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @Syn-McJ